[all-commits] [llvm/llvm-project] 0e8208: [libc++] Run the Lit test suite against an install...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Aug 28 06:23:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e8208eca1c316b7302de7803ab0d85a1dd77076
      https://github.com/llvm/llvm-project/commit/0e8208eca1c316b7302de7803ab0d85a1dd77076
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/cmake/caches/Apple.cmake
    M libcxx/modules/CMakeLists.txt
    M libcxx/src/CMakeLists.txt
    M libcxx/test/CMakeLists.txt
    M libcxx/test/configs/cmake-bridge.cfg.in
    R libcxx/test/configs/llvm-libc++-mingw.cfg.in
    M libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
    A libcxx/test/configs/llvm-libc++-shared-mingw.cfg.in
    M libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in
    A libcxx/test/configs/llvm-libc++-static-mingw.cfg.in
    M libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
    M libcxx/utils/ci/apple-install-libcxx.sh
    M libcxx/utils/ci/run-buildbot

  Log Message:
  -----------
  [libc++] Run the Lit test suite against an installed version of the library (#96910)

We always strive to test libc++ as close as possible to the way we are
actually shipping it. This was approximated reasonably well by setting
up the minimal driver flags when running the test suite, however we were
running the test suite against the library located in the build
directory.

This patch improves the situation by installing the library (the
headers, the built library, modules, etc) into a fake location and then
running the test suite against that fake "installation root".

This should open the door to getting rid of the temporary copy of the
headers we make during the build process, however this is left for a
future improvement.

Note that this adds quite a bit of verbosity whenever running the test
suite because we install the headers beforehand every time. We should be
able to override this to silence it, however CMake doesn't currently
give us a way to do that, see https://gitlab.kitware.com/cmake/cmake/-/issues/26085.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list