[all-commits] [llvm/llvm-project] 69c434: [LoopUnrollAnalyzer] Don't simplify signed pointer...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69c43468d3f21df6232fda0530f03f18b0f40345
      https://github.com/llvm/llvm-project/commit/69c43468d3f21df6232fda0530f03f18b0f40345
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M llvm/lib/Analysis/LoopUnrollAnalyzer.cpp
    M llvm/unittests/Analysis/UnrollAnalyzerTest.cpp

  Log Message:
  -----------
  [LoopUnrollAnalyzer] Don't simplify signed pointer comparison

We're generally not able to simplify signed pointer comparisons
(because we don't have no-wrap flags that would permit it), so
we shouldn't pretend that we can in the cost model.

The unsigned comparison case is also not modelled correctly,
as explained in the added comment. As this is a cost model
inaccuracy at worst, I'm leaving it alone for now.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications