[all-commits] [llvm/llvm-project] d0fe52: [AMDGPU] Fix sign confusion in performMulLoHiCombi...

Jay Foad via All-commits all-commits at lists.llvm.org
Tue Aug 27 09:10:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d0fe52d95194db09b3486378eae1b5ca5d0a286a
      https://github.com/llvm/llvm-project/commit/d0fe52d95194db09b3486378eae1b5ca5d0a286a
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2024-08-27 (Tue, 27 Aug 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/div-rem-by-constant-64.ll
    M llvm/test/CodeGen/AMDGPU/mul_int24.ll

  Log Message:
  -----------
  [AMDGPU] Fix sign confusion in performMulLoHiCombine (#105831)

SMUL_LOHI and UMUL_LOHI are different operations because the high part
of the result is different, so it is not OK to optimize the signed
version to MUL_U24/MULHI_U24 or the unsigned version to
MUL_I24/MULHI_I24.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list