[all-commits] [llvm/llvm-project] 2d37e4: [compiler-rt][test] Add REQUIRES: shell in tests t...

[Harini0924 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d37e48e2439f70ed394bcca5c065ca2c8f5ae94
      https://github.com/llvm/llvm-project/commit/2d37e48e2439f70ed394bcca5c065ca2c8f5ae94
  Author: Harini0924 <79345568+Harini0924 at users.noreply.github.com>
  Date:   2024-08-26 (Mon, 26 Aug 2024)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Linux/allocator_oom_test.cpp
    M compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cpp
    M compiler-rt/test/fuzzer/merge-posix.test
    M compiler-rt/test/fuzzer/ulimit.test
    M compiler-rt/test/hwasan/TestCases/print-memory-usage.c
    M compiler-rt/test/msan/Linux/reexec_unlimited_stack.cpp

  Log Message:
  -----------
  [compiler-rt][test] Add REQUIRES: shell in tests that use the `ulimit` command (#105339)

This patch adds the `REQUIRES: shell` directive to six test files that
use the `ulimit` command, ensuring these tests are only run in
environments where a full POSIX-compliant shell is available. The lit
internal shell does not use or support the `ulimit` command, which
causes failures when running tests with `LIT_USE_INTERNAL_SHELL=1 ninja
check-compiler-rt`
Specifically, one of the errors encountered is: 
```
# RUN: at line 4
ulimit -s 1000
# executed command: ulimit -s 1000
# .---command stderr------------
# | 'ulimit': command not found
# `-----------------------------
# error: command failed with exit status: 127
```
Since, the lit internal shell doesn't support `ulimit`, adding this
requirement prevents these tests from failing in the lit internal shell,
thereby improving the reliability of the test suite in environments
where the full shell is not available.

This change is relevant for [[RFC] Enabling the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179/3)
fixes:  #102398



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications