[all-commits] [llvm/llvm-project] 0b9a69: [mlir][Transforms] Dialect conversion: Fix bug in ...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/rollback_unmat
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b9a69b3beb03f0de9b3c699e9b32a7b61b3ca57
      https://github.com/llvm/llvm-project/commit/0b9a69b3beb03f0de9b3c699e9b32a7b61b3ca57
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Dialect conversion: Fix bug in `UnresolvedMaterializationRewrite` rollback

When an unresolved materializations (`unrealized_conversion_cast` op) is rolled back, the mapping should be rolled back as well, regardless of whether it is a source, target or argument materialization. Otherwise, we accumulate pointers to erased IR in the `mapping`. This is harmless in most cases, but can cause issues when a new operation is allocated at the same memory location and the pointer is "reused".

It is not possible to write a test case for this because I cannot trigger the pointer reuse programmatically.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications