[all-commits] [llvm/llvm-project] 3e763d: [SPIRV] Fix return type mismatch for createSPIRVEm...

Justin Bogner via All-commits all-commits at lists.llvm.org
Fri Aug 23 14:56:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e763db81607c71d0bb2eb4c01721ac6965d8de7
      https://github.com/llvm/llvm-project/commit/3e763db81607c71d0bb2eb4c01721ac6965d8de7
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp

  Log Message:
  -----------
  [SPIRV] Fix return type mismatch for createSPIRVEmitNonSemanticDIPass (#105889)

The declaration in SPIRV.h had this returning a `MachineFunctionPass *`,
but the implementation returned a `FunctionPass *`. This showed up as a
build error on windows, but it was clearly a mistake regardless.

I also updated the pass to include SPIRV.h rather than using its own
declarations for pass initialization, as this results in better errors
for this kind of typo.

Fixes a build break after #97558



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list