[all-commits] [llvm/llvm-project] 4dbaef: [mlir][Linalg] Avoid doing op replacement in `lina...

[MaheshRavishankar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4dbaef6d5ea71fb183114a82da4028960906c42b
      https://github.com/llvm/llvm-project/commit/4dbaef6d5ea71fb183114a82da4028960906c42b
  Author: MaheshRavishankar <1663364+MaheshRavishankar at users.noreply.github.com>
  Date:   2024-08-23 (Fri, 23 Aug 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
    M mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgDropUnitDims.cpp

  Log Message:
  -----------
  [mlir][Linalg] Avoid doing op replacement in `linalg::dropUnitDims`. (#105749)

It is better to do the replacement in the caller. This avoids the
footgun if the caller needs the original operation. Instead return the
produced operation and replacement values.

Signed-off-by: MaheshRavishankar <mahesh.ravishankar at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications