[all-commits] [llvm/llvm-project] e49068: [mlir] [tablegen] Make `hasSummary` and `hasDescri...

[Alex Rice via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e49068624c48f4d906707b32b31f6a1d561605be
      https://github.com/llvm/llvm-project/commit/e49068624c48f4d906707b32b31f6a1d561605be
  Author: Alex Rice <alexrice999 at hotmail.co.uk>
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
    M mlir/lib/TableGen/Operator.cpp

  Log Message:
  -----------
  [mlir] [tablegen] Make `hasSummary` and `hasDescription` useful (#105531)

The `hasSummary` and `hasDescription` functions are currently useless as
they check if the corresponding `summary` and `description` are present.
However, these values are set to a default value of `""`, and so these
functions always return true.

This PR changes these functions to check if the summary and description
are just whitespace, which is presumably closer to their original
intent.

@math-fehr 
@zero9178



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications