[all-commits] [llvm/llvm-project] 9b25ad: [CodeGenPrepare][X86] Add tests for fixing `urem` ...

[goldsteinn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9b25ad818c0b82fe4db8b43e9c9700805a2c7322
      https://github.com/llvm/llvm-project/commit/9b25ad818c0b82fe4db8b43e9c9700805a2c7322
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M llvm/test/CodeGen/X86/fold-loop-of-urem.ll
    M llvm/test/Transforms/CodeGenPrepare/X86/fold-loop-of-urem.ll

  Log Message:
  -----------
  [CodeGenPrepare][X86] Add tests for fixing `urem` transform; NFC


  Commit: e4c67ba67ee25e74bbcb719f90dba6e2e9ce41a0
      https://github.com/llvm/llvm-project/commit/e4c67ba67ee25e74bbcb719f90dba6e2e9ce41a0
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/CodeGenPrepare.cpp
    M llvm/test/CodeGen/X86/fold-loop-of-urem.ll
    M llvm/test/Transforms/CodeGenPrepare/X86/fold-loop-of-urem.ll

  Log Message:
  -----------
  Recommit "[CodeGenPrepare] Folding `urem` with loop invariant value"

Was missing remainder on `Start` value.

Also changed logic as as nikic suggested (getting loop from `PN`
instead of `Rem`). The prior impl increased the complexity of the code
and made debugging it more difficult.

Closes #104877


Compare: https://github.com/llvm/llvm-project/compare/dfc3494d48f0...e4c67ba67ee2

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications