[all-commits] [llvm/llvm-project] 39e308: [clang][NFC] Split invalid-cpu-note tests (#104601)

[Sam Elliott via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 39e3085a55880dbbc5aeddc3661342980d5e1467
      https://github.com/llvm/llvm-project/commit/39e3085a55880dbbc5aeddc3661342980d5e1467
  Author: Sam Elliott <quic_aelliott at quicinc.com>
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
    R clang/test/Misc/target-invalid-cpu-note.c
    A clang/test/Misc/target-invalid-cpu-note/aarch64.c
    A clang/test/Misc/target-invalid-cpu-note/amdgcn.c
    A clang/test/Misc/target-invalid-cpu-note/arm.c
    A clang/test/Misc/target-invalid-cpu-note/avr.c
    A clang/test/Misc/target-invalid-cpu-note/bpf.c
    A clang/test/Misc/target-invalid-cpu-note/hexagon.c
    A clang/test/Misc/target-invalid-cpu-note/lanai.c
    A clang/test/Misc/target-invalid-cpu-note/mips.c
    A clang/test/Misc/target-invalid-cpu-note/nvptx.c
    A clang/test/Misc/target-invalid-cpu-note/powerpc.c
    A clang/test/Misc/target-invalid-cpu-note/r600.c
    A clang/test/Misc/target-invalid-cpu-note/riscv.c
    A clang/test/Misc/target-invalid-cpu-note/sparc.c
    A clang/test/Misc/target-invalid-cpu-note/systemz.c
    A clang/test/Misc/target-invalid-cpu-note/wasm.c
    A clang/test/Misc/target-invalid-cpu-note/x86.c

  Log Message:
  -----------
  [clang][NFC] Split invalid-cpu-note tests (#104601)

This change does two kinds of splits:
- Splits each target into a different file. Some targets are left in the
same files, such as riscv32/64 and x86/_64 as these tests and lists are
very similar.
- Splits up the very long 'note:' lines which contain a list of CPUs,
using `CHECK-SAME`. There was a note about this not being possible
before, but with `{{^}}`, this is now possible -- I have
verified that this does the right thing if a single CPU anywhere in the
list is left out.

These tests had become quite annoying to change when adding a CPU, and I
believe this change makes these easier to maintain, and should cut down
on conflicts in these files (or at least makes conflicts easier to
resolve).

I apologise in advance for downstream conflicts, but hopefully that's a
small amount of short term pain, in return for fewer conflicts in
future.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications