[all-commits] [llvm/llvm-project] cde806: [lld][MachO] Fix a suspicous assert in SyntheticSe...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cde806b0e63fddcca013536b4bd55e45607205d1
      https://github.com/llvm/llvm-project/commit/cde806b0e63fddcca013536b4bd55e45607205d1
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
    M lld/MachO/SyntheticSections.cpp

  Log Message:
  -----------
  [lld][MachO] Fix a suspicous assert in SyntheticSections.cpp

This was comparing some .size() (uint64_t) against the sizeof a size_t
which changes with system bitness. This produced a warning that
brought this to my attention.

These tests were failing too on 32 bit Arm only:
  lld :: MachO/objc-category-merging-complete-test.s
  lld :: MachO/objc-category-merging-minimal.s

The assert I think meant to check the value of target->wordSize,
not the size of its type. Which is a type that changes size between
systems.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications