[all-commits] [llvm/llvm-project] cb7614: [mlir][Transforms] Dialect conversion: Fix bug in ...
Matthias Springer via All-commits
all-commits at lists.llvm.org
Sat Aug 17 00:43:51 PDT 2024
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: cb7614e839148196c53711fdee639e6dff933a8d
https://github.com/llvm/llvm-project/commit/cb7614e839148196c53711fdee639e6dff933a8d
Author: Matthias Springer <me at m-sp.org>
Date: 2024-08-17 (Sat, 17 Aug 2024)
Changed paths:
M mlir/lib/Transforms/Utils/DialectConversion.cpp
M mlir/test/Transforms/test-legalize-type-conversion.mlir
Log Message:
-----------
[mlir][Transforms] Dialect conversion: Fix bug in `computeNecessaryMaterializations` (#104630)
There was a typo in the code path that removes unnecessary
materializations.
Before: Update `opResult` (result of an op different from `user`) in
mapping and remove `user`.
```
replaceMaterialization(rewriterImpl, opResult, inputOperands,
inverseMapping);
necessaryMaterializations.remove(materializationOps.lookup(user));
```
After: Update `user->getResults()` in mapping and remove `user`.
```
replaceMaterialization(rewriterImpl, user->getResults(), inputOperands,
inverseMapping);
necessaryMaterializations.remove(materializationOps.lookup(user));
```
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list