[all-commits] [llvm/llvm-project] 71d54f: [DirectX] Revert specialized createOp methods part...

Justin Bogner via All-commits all-commits at lists.llvm.org
Fri Aug 16 12:21:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 71d54faa65f490f2a2825e591c3eb25ff7996221
      https://github.com/llvm/llvm-project/commit/71d54faa65f490f2a2825e591c3eb25ff7996221
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M llvm/lib/Target/DirectX/DXILOpBuilder.cpp
    M llvm/lib/Target/DirectX/DXILOpBuilder.h

  Log Message:
  -----------
  [DirectX] Revert specialized createOp methods part of #101250

In 8cf85653b6f5 "[DirectX] Make DXILOpBuilder's API more useable" we introduced
specialized createOp methods for each DirectX op for convenience, but the API
is buggy and untested. It also isn't actually as useful as I imagined it would
be since we don't have argument names or const-ness represented in DXIL.td
currently. Remove these methods for now and we can reintroduce them if we
actually need them later.

Pull Request: https://github.com/llvm/llvm-project/pull/104245



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list