[all-commits] [llvm/llvm-project] cf721e: [PowerPC] Do not merge TLS constants within PPCMer...

Amy Kwan via All-commits all-commits at lists.llvm.org
Fri Aug 16 12:07:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cf721e29c6a3f220bd66475b7d29aff7fe9d56e3
      https://github.com/llvm/llvm-project/commit/cf721e29c6a3f220bd66475b7d29aff7fe9d56e3
  Author: Amy Kwan <amy.kwan1 at ibm.com>
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
    M llvm/lib/Target/PowerPC/PPCMergeStringPool.cpp
    A llvm/test/CodeGen/PowerPC/mergeable-string-pool-tls.ll

  Log Message:
  -----------
  [PowerPC] Do not merge TLS constants within PPCMergeStringPool.cpp (#94059)

This patch prevents thread-local constants to be merged within
PPCMergeStringPool.cpp.

The PPCMergeStringPool pass primarily merges non-thread-local constants
together, and thread-local constants should not be mixed together with
other (non-thread-local) constants. In the event that thread-local and
other non-thread-local constants are pooled together, the
llvm.threadlocal.address intrinsic can fail as it expects its argument
to be a thread-local global value, but the merged string structure
created by the PPCMergeStringPool pass is not thread-local as a whole.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list