[all-commits] [llvm/llvm-project] 26670e: [lldb] Correctly fix a usage of `PATH_MAX`, and fi...

[royitaqi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26670e7fa4f032a019d23d56c6a02926e854e8af
      https://github.com/llvm/llvm-project/commit/26670e7fa4f032a019d23d56c6a02926e854e8af
  Author: royitaqi <royitaqi at users.noreply.github.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M lldb/include/lldb/lldb-private-types.h
    M lldb/source/Utility/RealpathPrefixes.cpp
    M lldb/unittests/Utility/FileSpecListTest.cpp
    M lldb/unittests/Utility/RealpathPrefixesTest.cpp

  Log Message:
  -----------
  [lldb] Correctly fix a usage of `PATH_MAX`, and fix unit tests (#104502)

# Part 1: Correctly fix a usage of `PATH_MAX`

TL;DR: Adding a typedef `lldb_private::PathSmallString` which contains a
hardcoded initial size (128).

# Part 2: Fix unit tests

After https://github.com/llvm/llvm-project/pull/104493 fixed the build
break for Windows, unit test failure showed up for Windows. The
root-cause is that the `FileSpec`'s in the unit tests are not
style-specific. The fix is to apply either `WindowsSpec` or `PosixSpec`
specifically.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications