[all-commits] [llvm/llvm-project] 52337d: llvm-objdump: ensure a MachO symbol isn't STAB bef...

Tim Northover via All-commits all-commits at lists.llvm.org
Thu Aug 15 11:19:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 52337d5f9d108f04b2ed06069b21a255c232dc1f
      https://github.com/llvm/llvm-project/commit/52337d5f9d108f04b2ed06069b21a255c232dc1f
  Author: Tim Northover <t.p.northover at gmail.com>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    A llvm/test/tools/llvm-objdump/macho-stabs-in-syms.yaml
    M llvm/tools/llvm-objdump/llvm-objdump.cpp

  Log Message:
  -----------
  llvm-objdump: ensure a MachO symbol isn't STAB before looking up secion (#86667)

The section field has been repurposed for some STAB symbol types, and if
we blindly look it up we'll produce an error and terminate. Logic
already existed

Existing stabs test had a section that was in range. Unfortunately I
don't know of an easy way to produce stabs entries in LLVM (I thought
they died in the 90s until this came up) so I just binary-edited it to
cause a failure on existing llvm-objdump.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list