[all-commits] [llvm/llvm-project] 64c856: Revert "[Object][x86-64] Add support for `R_X86_64...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Aug 15 09:01:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64c856055aed97603510410fd2feab273e1d5b8a
      https://github.com/llvm/llvm-project/commit/64c856055aed97603510410fd2feab273e1d5b8a
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M llvm/lib/Object/RelocationResolver.cpp

  Log Message:
  -----------
  Revert "[Object][x86-64] Add support for `R_X86_64_GLOB_DAT` relocations. (#103029)" (#103497)

This reverts commit 5ae9faa538d100ab38f6f4f99c924de0e4270272.

RelocationResolver is only supposed to handle static relocation types.
Introducing GLOB_DAT could negatively impact other RelocationResolver
users who solely handle static relocations and want to report errors for
dynamic relocations.

If GLOB_DAT is the sole required relocation, explicitly checking for it
in the caller would be more reliable. Additionally, the caller should
handle GLOB_DAT on other architectures.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list