[all-commits] [llvm/llvm-project] 57a19a: Reapply "[lldb] Tolerate multiple compile units wi...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9
      https://github.com/llvm/llvm-project/commit/57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2024-08-15 (Thu, 15 Aug 2024)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
    A lldb/test/Shell/SymbolFile/DWARF/x86/dwp-hash-collision.s

  Log Message:
  -----------
  Reapply "[lldb] Tolerate multiple compile units with the same DWO ID (#100577)" (#104041)

The only change vs. the first version of the patch is that I've made
DWARFUnit linking thread-safe/unit. This was necessary because, during
the
indexing step, two skeleton units could attempt to associate themselves
with the split unit.

The original commit message was:

I ran into this when LTO completely emptied two compile units, so they
ended up with the same hash (see #100375). Although, ideally, the
compiler would try to ensure we don't end up with a hash collision even
in this case, guaranteeing their absence is practically impossible. This
patch ensures this situation does not bring down lldb.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications