[all-commits] [llvm/llvm-project] 21cea3: AMDGPU: Stop promoting allocas with addrspacecast ...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 21cea3f3be51d5c3856b87fed301b5fc3dddade4
      https://github.com/llvm/llvm-project/commit/21cea3f3be51d5c3856b87fed301b5fc3dddade4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
    M llvm/test/CodeGen/AMDGPU/promote-alloca-addrspacecast.ll

  Log Message:
  -----------
  AMDGPU: Stop promoting allocas with addrspacecast users (#104051)

We cannot promote this case unless we know the value is only
observed through flat operations. We cannot analyze this through
a call. PointerMayBeCaptured was an imprecise check for this.
A callee with a nocapture attribute may still cast to private and
observe the address space, so really we need a different notion
of nocapture.

I doubt this was of any use anyway. The promotable cases should
have optimized out addrspacecast to begin earlier.

Fixes #66669
Fixes #104035



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications