[all-commits] [llvm/llvm-project] 4f5d86: [llvm-lit] Add REQUIRES: shell to BOLT permission ...

[Harini0924 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4f5d866af7fed0de1671a68530d3023e9762b71e
      https://github.com/llvm/llvm-project/commit/4f5d866af7fed0de1671a68530d3023e9762b71e
  Author: Harini0924 <79345568+Harini0924 at users.noreply.github.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M bolt/test/permission.test

  Log Message:
  -----------
  [llvm-lit] Add REQUIRES: shell to BOLT permission test for lit internal shell (#103012)

This patch adds the `REQUIRES: shell` directive to the BOLT permission
test to ensure it only runs in environments with a full-featured
Unix-like shell. This change is necessary because the test relies on
advanced shell capabilities that are not supported by lit's internal
shell.

**Reasoning:** The BOLT permission test uses features like running
commands in the background with `&`, performing arithmetic operations,
and handling special number formats (octal). These features require a
more capable shell than what lit's internal shell provides. Without a
proper shell, the test could fail or behave unpredictably.

This change is relevant for enabling the lit internal shell by default,
as outlined in [[RFC] Enabling the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications