[all-commits] [llvm/llvm-project] 643a20: [llvm-lit] Fix error in compiler-rt tests when usi...

Harini0924 via All-commits all-commits at lists.llvm.org
Tue Aug 13 15:14:13 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 643a2080ec028bd7674206e0f97cbc7d0f132f99
      https://github.com/llvm/llvm-project/commit/643a2080ec028bd7674206e0f97cbc7d0f132f99
  Author: Harini0924 <79345568+Harini0924 at users.noreply.github.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M compiler-rt/test/dfsan/custom.cpp
    M compiler-rt/test/dfsan/flags.c
    M compiler-rt/test/dfsan/fork.cpp
    M compiler-rt/test/dfsan/origin_limit.c
    M compiler-rt/test/msan/Linux/sendmsg.cpp
    M compiler-rt/test/msan/chained_origin_empty_stack.cpp
    M compiler-rt/test/msan/chained_origin_limits.cpp
    M compiler-rt/test/msan/coverage-levels.cpp
    M compiler-rt/test/msan/dtor-member.cpp
    M compiler-rt/test/msan/fork.cpp
    M compiler-rt/test/msan/interception_sigaction_test.cpp
    M compiler-rt/test/msan/memcmp_test.cpp
    M compiler-rt/test/msan/msan_check_mem_is_initialized.cpp
    M compiler-rt/test/msan/poison_in_free.cpp
    M compiler-rt/test/msan/print_stats.cpp
    M compiler-rt/test/msan/recover-dso.cpp
    M compiler-rt/test/msan/recover.cpp
    M compiler-rt/test/msan/release_origin.c
    M compiler-rt/test/msan/strcmp.c
    M compiler-rt/test/msan/strndup.cpp
    M compiler-rt/test/profile/Linux/instrprof-comdat.test
    M compiler-rt/test/sanitizer_common/TestCases/Linux/signal_segv_handler.cpp
    M compiler-rt/test/ubsan/TestCases/Misc/Linux/static-link.cpp
    M compiler-rt/test/xray/TestCases/Posix/arg1-arg0-logging.cpp
    M compiler-rt/test/xray/TestCases/Posix/arg1-logger.cpp
    M compiler-rt/test/xray/TestCases/Posix/arg1-logging-implicit-this.cpp
    M compiler-rt/test/xray/TestCases/Posix/argv0-log-file-name.cpp
    M compiler-rt/test/xray/TestCases/Posix/coverage-sample.cpp
    M compiler-rt/test/xray/TestCases/Posix/fdr-reinit.cpp
    M compiler-rt/test/xray/TestCases/Posix/fixedsize-logging.cpp
    M compiler-rt/test/xray/TestCases/Posix/func-id-utils.cpp
    M compiler-rt/test/xray/TestCases/Posix/optional-inmemory-log.cpp
    M compiler-rt/test/xray/TestCases/Posix/patching-unpatching.cpp
    M compiler-rt/test/xray/TestCases/Posix/pic_test.cpp
    M compiler-rt/test/xray/TestCases/Posix/typed-event-logging.cpp

  Log Message:
  -----------
  [llvm-lit] Fix error in compiler-rt tests when using lit internal shell with env (#102069)

When running tests in compiler-rt using the lit internal shell with the
following command:
```
LIT_USE_INTERNAL_SHELL=1 ninja check-compiler-rt
```
one common error that occurs is:
```
'XRAY_OPTIONS=patch_premain=false:verbosity=1': command not found
```
This error, along with over 50 similar "environment variable not found"
errors, appears across 35 files in complier-rt. These errors happen
because the environment variables are not being set correctly when the
internal shell is used, leading to commands failing due to unrecognized
environment variables.

This patch addresses the issue by using the `env` command to properly
set the environment variables before running the tests. By explicitly
setting the environment variables through `env`, the internal shell can
correctly interpret and apply them, allowing the tests to pass.
fixes: #102395 
[link to
RFC](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list