[all-commits] [llvm/llvm-project] eade1f: AtomicExpand: Stop trying to prune cmpxchg extract...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Aug 13 08:55:27 PDT 2024


  Branch: refs/heads/users/arsenm/atomic-expand-remove-prune
  Home:   https://github.com/llvm/llvm-project
  Commit: eade1f6095faba96e1680ad8cc4221edde762334
      https://github.com/llvm/llvm-project/commit/eade1f6095faba96e1680ad8cc4221edde762334
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/AtomicExpandPass.cpp
    M llvm/test/Transforms/AtomicExpand/ARM/cmpxchg-weak.ll

  Log Message:
  -----------
  AtomicExpand: Stop trying to prune cmpxchg extractvalue users

The expansion for cmpxchg was trying to tidy up extractvalue users
to directly use the lowered pieces, and then erasing the now dead
extractvalues. This was making an assumption about the iteration
order did not depend on those user instructions.

Continue doing the replacement, but just leave the dead extractvalues.
This is a minor regression, but it is of no importance since the
dead instructions will just get dropped during codegen anyway.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list