[all-commits] [llvm/llvm-project] 332177: AtomicExpand: Stop precollecting atomic instructio...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Aug 13 07:10:25 PDT 2024


  Branch: refs/heads/users/arsenm/atomic-expand-stop-precollecting-atomic-instrs
  Home:   https://github.com/llvm/llvm-project
  Commit: 332177dab0b499172ddad6c21dd3453ff0cdccf3
      https://github.com/llvm/llvm-project/commit/332177dab0b499172ddad6c21dd3453ff0cdccf3
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/AtomicExpandPass.cpp
    M llvm/test/CodeGen/NVPTX/atomics-sm70.ll
    M llvm/test/CodeGen/NVPTX/atomics-sm90.ll
    M llvm/test/CodeGen/PowerPC/all-atomics.ll
    M llvm/test/CodeGen/X86/atomic6432.ll
    M llvm/test/CodeGen/X86/pr5145.ll

  Log Message:
  -----------
  AtomicExpand: Stop precollecting atomic instructions in function

Move the processing of an instruction into a helper function. Also
avoid redundant checking for all types of atomic instructions.
Including the assert, it was effectively performing the same check
3 times.


  Commit: ac04cf09fe23058b8e38e520b41ead224b6f6e0b
      https://github.com/llvm/llvm-project/commit/ac04cf09fe23058b8e38e520b41ead224b6f6e0b
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/AtomicExpandPass.cpp

  Log Message:
  -----------
  Move instruction handling cases together


  Commit: dc606e8001e5d1d2655a93b5c0c6286f6e7f812b
      https://github.com/llvm/llvm-project/commit/dc606e8001e5d1d2655a93b5c0c6286f6e7f812b
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/AtomicExpandPass.cpp
    M llvm/test/CodeGen/NVPTX/atomics-sm70.ll
    M llvm/test/CodeGen/NVPTX/atomics-sm90.ll
    M llvm/test/CodeGen/PowerPC/all-atomics.ll
    M llvm/test/CodeGen/X86/atomic6432.ll
    M llvm/test/CodeGen/X86/pr5145.ll

  Log Message:
  -----------
  Revert the iteration change

Only keep the refactor of the main loop body into a function.
Keep the worklist for now, later patch would have just un-inverted
it later.


Compare: https://github.com/llvm/llvm-project/compare/daf9612f4c21...dc606e8001e5

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list