[all-commits] [llvm/llvm-project] 28f2d0: [AIX] Revert `#pragma mc_func` check (#102919)
Qiongsi Wu via All-commits
all-commits at lists.llvm.org
Tue Aug 13 05:04:50 PDT 2024
Branch: refs/heads/release/19.x
Home: https://github.com/llvm/llvm-project
Commit: 28f2d04b3ca36faffe997fa86833e5ed83699272
https://github.com/llvm/llvm-project/commit/28f2d04b3ca36faffe997fa86833e5ed83699272
Author: Qiongsi Wu <274595+qiongsiwu at users.noreply.github.com>
Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths:
M clang/include/clang/Basic/DiagnosticParseKinds.td
M clang/include/clang/Driver/Options.td
M clang/include/clang/Lex/PreprocessorOptions.h
M clang/include/clang/Parse/Parser.h
M clang/lib/Driver/ToolChains/AIX.cpp
M clang/lib/Parse/ParsePragma.cpp
R clang/test/Preprocessor/pragma_mc_func.c
Log Message:
-----------
[AIX] Revert `#pragma mc_func` check (#102919)
https://github.com/llvm/llvm-project/pull/99888 added a specific
diagnostic for `#pragma mc_func` on AIX. There are some disagreements
on:
1. If the check should be on by default. Leaving the check off by
default is dangerous, since it is difficult to be aware of such a check.
Turning it on by default at the moment causes build failures on AIX. See
https://github.com/llvm/llvm-project/pull/101336 for more details.
2. If the check can be made more general. See
https://github.com/llvm/llvm-project/pull/101336#issuecomment-2269283906.
This PR reverts this check from `main` so we can flush out these
disagreements.
(cherry picked from commit 123b6fcc70af17d81c903b839ffb55afc9a9728f)
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list