[all-commits] [llvm/llvm-project] a9636b: [mlir][StorageUniquer] Restore old signature for d...

[Benjamin Chetioui via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a9636b7f60f283926c66e96c036f5b5d9e57c026
      https://github.com/llvm/llvm-project/commit/a9636b7f60f283926c66e96c036f5b5d9e57c026
  Author: Benjamin Chetioui <3920784+bchetioui at users.noreply.github.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M mlir/include/mlir/IR/StorageUniquerSupport.h

  Log Message:
  -----------
  [mlir][StorageUniquer] Restore old signature for default implementaion of verifyInvariants. (#103023)

PR #102326 changed the prototype of the default implementation of verify
to include emitErrorFn.

This breaks automatic derivation in consumer attributes, such as
https://github.com/tensorflow/runtime/blob/60277ba976739502e45ad26585e071568fa44af1/include/tfrt/core_runtime/opdefs/attributes.h#L53.

This PR simply restores the signature to what it was prior to PR
#102326.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications