[all-commits] [llvm/llvm-project] c261de: [lldb] Fix crash when adding members to an "incomp...

[Pavel Labath via All-commits]

  Branch: refs/heads/release/19.x
  Home:   https://github.com/llvm/llvm-project
  Commit: c261de724b01a1db029d896914adc8995cd2c35a
      https://github.com/llvm/llvm-project/commit/c261de724b01a1db029d896914adc8995cd2c35a
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    A lldb/test/Shell/SymbolFile/DWARF/x86/typedef-in-incomplete-type.cpp

  Log Message:
  -----------
  [lldb] Fix crash when adding members to an "incomplete" type (#102116)

This fixes a regression caused by delayed type definition searching
(#96755 and friends): If we end up adding a member (e.g. a typedef) to a
type that we've already attempted to complete (and failed), the
resulting AST would end up inconsistent (we would start to "forcibly"
complete it, but never finish it), and importing it into an expression
AST would crash.

This patch fixes this by detecting the situation and finishing the
definition as well.

(cherry picked from commit 57cd1000c9c93fd0e64352cfbc9fbbe5b8a8fcef)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications