[all-commits] [llvm/llvm-project] 9b9406: [CycleAnalysis] Methods to verify cycles and their...

[Sameer Sahasrabuddhe via All-commits]

  Branch: refs/heads/users/ssahasra/refactor-control-flow-hub
  Home:   https://github.com/llvm/llvm-project
  Commit: 9b94060a378ac4a44fbbd18856460b745e16e128
      https://github.com/llvm/llvm-project/commit/9b94060a378ac4a44fbbd18856460b745e16e128
  Author: Sameer Sahasrabuddhe <sameer.sahasrabuddhe at amd.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M llvm/include/llvm/ADT/GenericCycleImpl.h
    M llvm/include/llvm/ADT/GenericCycleInfo.h
    M llvm/include/llvm/ADT/GenericSSAContext.h
    M llvm/include/llvm/Analysis/CycleAnalysis.h
    M llvm/include/llvm/CodeGen/MachineSSAContext.h
    M llvm/include/llvm/IR/SSAContext.h
    M llvm/lib/Analysis/CycleAnalysis.cpp
    M llvm/lib/CodeGen/MachineCycleAnalysis.cpp
    M llvm/lib/IR/CycleInfo.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/test/Analysis/CycleInfo/basic.ll
    M llvm/test/Analysis/CycleInfo/unreachable-predecessor.ll

  Log Message:
  -----------
  [CycleAnalysis] Methods to verify cycles and their nesting.

The original implementation provided a simple method to check whether the forest
of nested cycles is well-formed. This is now augmented with other methods to
check well-formedness of every cycle, either invdividually, or as the entire
forest. These will be used by future transforms that modify CycleInfo.


  Commit: dcf945e70ffca99592cb4ec277c13b28ca80adda
      https://github.com/llvm/llvm-project/commit/dcf945e70ffca99592cb4ec277c13b28ca80adda
  Author: Sameer Sahasrabuddhe <sameer.sahasrabuddhe at amd.com>
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/BasicBlockUtils.h
    A llvm/include/llvm/Transforms/Utils/ControlFlowUtils.h
    M llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
    M llvm/lib/Transforms/Utils/CMakeLists.txt
    A llvm/lib/Transforms/Utils/ControlFlowUtils.cpp
    M llvm/lib/Transforms/Utils/FixIrreducible.cpp
    M llvm/lib/Transforms/Utils/UnifyLoopExits.cpp
    M llvm/test/CodeGen/AMDGPU/local-atomicrmw-fadd.ll
    M llvm/test/Transforms/FixIrreducible/basic.ll
    M llvm/test/Transforms/FixIrreducible/bug45623.ll
    M llvm/test/Transforms/FixIrreducible/nested.ll
    M llvm/test/Transforms/FixIrreducible/switch.ll
    M llvm/test/Transforms/FixIrreducible/unreachable.ll

  Log Message:
  -----------
  [Transforms] Refactor CreateControlFlowHub

CreateControlFlowHub is a method that redirects control flow edges from a set of
incoming blocks to a set of outgoing blocks through a new set of "guard" blocks.
This is now refactored into a separate file with one enhancement: The input to
the method is now a set of branches rather than two sets of blocks.

The original implementation reroutes every edge from incoming blocks to outgoing
blocks. But it is possible that for some incoming block InBB, some successor S
might be in the set of outgoing blocks, but that particular edge should not be
rerouted. The new implementation makes this possible by allowing the user to
specify the targets of each branch that need to be rerouted.

This is needed when improving the implementation of FixIrreducible #101386. Current
uses in FixIrreducible and UnifyLoopExits do not demonstrate this finer control
over the edges being rerouted.


Compare: https://github.com/llvm/llvm-project/compare/9b94060a378a%5E...dcf945e70ffc

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications