[all-commits] [llvm/llvm-project] b1edac: [Obj2Yaml] Add support for minidump generation wit...

Jacob Lalonde via All-commits all-commits at lists.llvm.org
Mon Aug 12 14:35:40 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b1edac0496f47374c9780f3f83c6773eed73a66e
      https://github.com/llvm/llvm-project/commit/b1edac0496f47374c9780f3f83c6773eed73a66e
  Author: Jacob Lalonde <jalalonde at fb.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/Minidump.h
    M llvm/include/llvm/Object/Minidump.h
    M llvm/include/llvm/ObjectYAML/MinidumpYAML.h
    M llvm/lib/Object/Minidump.cpp
    M llvm/lib/ObjectYAML/MinidumpEmitter.cpp
    M llvm/lib/ObjectYAML/MinidumpYAML.cpp
    M llvm/test/tools/obj2yaml/Minidump/basic.yaml
    M llvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp

  Log Message:
  -----------
  [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (#101272)

This PR adds support for `obj2yaml` and `yaml2obj` to generate minidumps
that have a Memory64List stream. This is a prerequisite to #101086.

Worth noting
- ~~const dropped on minidumps so we could cache a MemoryDescriptor_64
to it's actual offset, preventing the need to loop multiple times~~
- doesn't reuse the existing `ListStream` code in some places, because
the Memory64List has a different width size field (unsigned 64), and a
larger header than all the other streams. I determined refactoring the
existing code to support Mem64 would be worse than supporting the
special case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list