[all-commits] [llvm/llvm-project] b6448a: [ELF] Change "no PT_TLS" error to use errorOrWarn

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b6448a03d887a1615fdffd1016109f9f24bea275
      https://github.com/llvm/llvm-project/commit/b6448a03d887a1615fdffd1016109f9f24bea275
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M lld/ELF/InputSection.cpp
    M lld/ELF/Symbols.cpp
    M lld/test/ELF/invalid/tls-symbol.s
    M lld/test/ELF/linkerscript/phdrs-no-tls.test

  Log Message:
  -----------
  [ELF] Change "no PT_TLS" error to use errorOrWarn

so that --noinhibit-exec downgrades the error to a warning, which helps
debugging when `PHDRS` is specified without `PT_TLS`. Also update the
message to make it accurate: STT_TLS may exist in the absence of PT_TLS.

In addition, invoking `exitLld(1)` (through `fatal`) is problematic
(#66974): When a thread is `exitLld(1)`, triggering `llvm_shutdown`,
another thread may be at `relocateAlloc`, accessing `sec.relocs()` which
got destroyed(tampered?), leading to
incorrect `llvm_unreachable("invalid expression")`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications