[all-commits] [llvm/llvm-project] 4915fd: [Serialization] Add a callback to register new cre...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4915fddbb2d79b5d67794b88c23da8d296968d0e
      https://github.com/llvm/llvm-project/commit/4915fddbb2d79b5d67794b88c23da8d296968d0e
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-08-12 (Mon, 12 Aug 2024)

  Changed paths:
    M clang/include/clang/Frontend/MultiplexConsumer.h
    M clang/include/clang/Serialization/ASTDeserializationListener.h
    M clang/include/clang/Serialization/ASTReader.h
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Frontend/MultiplexConsumer.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    A clang/test/Modules/pr102684.cppm

  Log Message:
  -----------
  [Serialization] Add a callback to register new created predefined decls for DeserializationListener (#102855)

Close https://github.com/llvm/llvm-project/issues/102684

The root cause of the issue is, it is possible that the predefined decl
is not registered at the beginning of writing a module file but got
created during the process of writing from reading.

This is incorrect. The predefined decls should always be predefined
decls.

Another deep thought about the issue is, we shouldn't read any new
things after we start to write the module file. But this is another
deeper question.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications