[all-commits] [llvm/llvm-project] e908a0: [lldb] Move definition of SBSaveCoreOptions dtor o...

[Alex Langford via All-commits]

  Branch: refs/heads/release/19.x
  Home:   https://github.com/llvm/llvm-project
  Commit: e908a0099ce392d694eefbeda27aadfe54922ba5
      https://github.com/llvm/llvm-project/commit/e908a0099ce392d694eefbeda27aadfe54922ba5
  Author: Alex Langford <alangford at apple.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    M lldb/include/lldb/API/SBSaveCoreOptions.h
    M lldb/source/API/SBSaveCoreOptions.cpp

  Log Message:
  -----------
  [lldb] Move definition of SBSaveCoreOptions dtor out of header (#102539)

This class is technically not usable in its current state. When you use
it in a simple C++ project, your compiler will complain about an
incomplete definition of SaveCoreOptions. Normally this isn't a problem,
other classes in the SBAPI do this. The difference is that
SBSaveCoreOptions has a default destructor in the header, so the
compiler will attempt to generate the code for the destructor with an
incomplete definition of the impl type.

All methods for every class, including constructors and destructors,
must have a separate implementation not in a header.

(cherry picked from commit 101cf540e698529d3dd899d00111bcb654a3c12b)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications