[all-commits] [llvm/llvm-project] d89370: Revert "demangle function names in trace files (#8...

[Fangrui Song via All-commits]

  Branch: refs/heads/release/19.x
  Home:   https://github.com/llvm/llvm-project
  Commit: d893708ded7b5e8cfafae777bf88928761231994
      https://github.com/llvm/llvm-project/commit/d893708ded7b5e8cfafae777bf88928761231994
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    M clang/test/Driver/ftime-trace-sections.py
    M llvm/lib/IR/LegacyPassManager.cpp
    M llvm/lib/Passes/CMakeLists.txt
    M llvm/lib/Passes/StandardInstrumentations.cpp
    M utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

  Log Message:
  -----------
  Revert "demangle function names in trace files (#87626)"

This reverts commit 0fa20c55b58deb94090985a5c5ffda4d5ceb3cd1.

Storing raw symbol names is generally preferred in profile files.
Demangling might lose information. Language frontends might use
demangling schemes not supported by LLVMDemangle
(https://github.com/llvm/llvm-project/issues/45901#issuecomment-2008686663).
In addition, calling `demangle` for each function has a significant
performance overhead (#102222).

I believe that even if we decide to provide a producer-side demangling,
it would not be on by default.

Pull Request: https://github.com/llvm/llvm-project/pull/102274

(cherry picked from commit 72b73e23b6c36537db730ebea00f92798108a6e5)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications