[all-commits] [llvm/llvm-project] bbefd5: [TargetLowering] Handle vector types in expandFixe...

Björn Pettersson via All-commits all-commits at lists.llvm.org
Fri Aug 9 15:27:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bbefd5713ff55de3a23e4bdc7c15edd74cbc5e7a
      https://github.com/llvm/llvm-project/commit/bbefd5713ff55de3a23e4bdc7c15edd74cbc5e7a
  Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2024-08-10 (Sat, 10 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/test/CodeGen/AArch64/smul_fix.ll
    M llvm/test/CodeGen/AArch64/umul_fix.ll

  Log Message:
  -----------
  [TargetLowering] Handle vector types in expandFixedPointMul (#102635)

In TargetLowering::expandFixedPointMul when expanding fixed point
multiplication, and when using a widened MUL as strategy for the
lowering, there was a bug resulting in assertion failures like this:
   Assertion `VT.isVector() == N1.getValueType().isVector() &&
   "SIGN_EXTEND result type type should be vector iff the operand "
   "type is vector!"' failed.

Problem was that we did not consider that VT could be a vector type
when setting up the WideVT. This patch should fix that bug.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list