[all-commits] [llvm/llvm-project] 5123f2: [mlir][vector][test] Split tests from vector-trans...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5123f2c60a6a357c0384dae6b189fa0f63ba34ef
      https://github.com/llvm/llvm-project/commit/5123f2c60a6a357c0384dae6b189fa0f63ba34ef
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    A mlir/test/Dialect/Vector/drop-unit-dims-with-shape-cast.mlir
    M mlir/test/Dialect/Vector/vector-transfer-flatten.mlir

  Log Message:
  -----------
  [mlir][vector][test] Split tests from vector-transfer-flatten.mlir (#102584)

Move tests that exercise DropUnitDimFromElementwiseOps and
DropUnitDimsFromTransposeOp to a dedicated file.

While these patterns are collected under populateFlattenVectorTransferPatterns
(and are tested via -test-vector-transfer-flatten-patterns), they can actually
be tested without the xfer Ops, and hence the split.

Note, this is mostly just moving tests from one file to another. The only real
change is the removal of the following check-lines:

```mlir
//   CHECK-128B-NOT:   memref.collapse_shape
```

These were added specifically to check the "flattening" logic (which introduces
`memref.collapse_shape`). However, these tests were never meant to test that
logic (in fact, that's the reason I am moving them to a different file) and
hence are being removed as copy&paste errors.

I also removed the following TODO:

```mlir
/// TODO: Potential duplication with tests from:
///   * "vector-dropleadunitdim-transforms.mlir"
///   * "vector-transfer-drop-unit-dims-patterns.mlir"
```
I've checked what patterns are triggered in those test files and neither
DropUnitDimFromElementwiseOps nor DropUnitDimsFromTransposeOp does.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications