[all-commits] [llvm/llvm-project] fdf8e3: [Modules][Diagnostic] Mention which AST file's opt...

[Volodymyr Sapsai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fdf8e3e31103bc81917cdb27150877f524bb2669
      https://github.com/llvm/llvm-project/commit/fdf8e3e31103bc81917cdb27150877f524bb2669
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSerializationKinds.td
    M clang/include/clang/Serialization/ASTReader.h
    M clang/lib/Frontend/ASTUnit.cpp
    M clang/lib/Frontend/FrontendActions.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/test/Modules/check-for-sanitizer-feature.cpp
    M clang/test/Modules/ignored_macros.m
    M clang/test/Modules/load_failure.c
    M clang/test/Modules/merge-target-features.cpp
    M clang/test/Modules/mismatch-diagnostics.cpp
    M clang/test/Modules/module-pch-different-cache-path.c
    M clang/test/Modules/pr62359.cppm
    M clang/test/PCH/arc.m
    M clang/test/PCH/fuzzy-pch.c
    M clang/test/PCH/module-hash-difference.m
    M clang/test/PCH/ms-pch-macro.c
    M clang/test/PCH/no-validate-pch.cl

  Log Message:
  -----------
  [Modules][Diagnostic] Mention which AST file's options differ from the current TU options. (#101413)

Claiming a mismatch is always in a precompiled header is wrong and
misleading as a mismatch can happen in any provided AST file. Emitting a
path for a file with a problem allows to disambiguate between multiple
input files.

Use generic term "AST file" because we don't always know a kind of the
provided file (for example, see `ASTReader::readASTFileControlBlock`).

rdar://65005546



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications