[all-commits] [llvm/llvm-project] e72d95: [C++20] [Modules] Don't diagnose duplicated implic...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Wed Aug 7 22:30:21 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e72d956b99e920b0fe2a7946eb3a51b9e889c73c
      https://github.com/llvm/llvm-project/commit/e72d956b99e920b0fe2a7946eb3a51b9e889c73c
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M clang/lib/Serialization/ASTReaderDecl.cpp
    A clang/test/Modules/pr102349.cppm
    A clang/test/Modules/pr102360.cppm

  Log Message:
  -----------
  [C++20] [Modules] Don't diagnose duplicated implicit decl in multiple named modules (#102423)

Close https://github.com/llvm/llvm-project/issues/102360 
Close https://github.com/llvm/llvm-project/issues/102349

http://eel.is/c++draft/basic.def.odr#15.3 makes it clear that the
duplicated deinition are not allowed to be attached to named modules.

But we need to filter the implicit declarations as user can do nothing
about it and the diagnostic message is annoying.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list