[all-commits] [llvm/llvm-project] 8ce5a3: [TableGen] Rework error reporting for duplicate Fe...

[Rahul Joshi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ce5a32f0221b301e4a74c2263d9cbd240114ee0
      https://github.com/llvm/llvm-project/commit/8ce5a32f0221b301e4a74c2263d9cbd240114ee0
  Author: Rahul Joshi <rjoshi at nvidia.com>
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
    M llvm/include/llvm/TableGen/Record.h
    A llvm/test/TableGen/ProcessorUniqueNames.td
    M llvm/test/TableGen/SubtargetFeatureUniqueNames.td
    M llvm/utils/TableGen/Common/CMakeLists.txt
    M llvm/utils/TableGen/Common/CodeGenSchedule.cpp
    M llvm/utils/TableGen/Common/Types.h
    A llvm/utils/TableGen/Common/Utils.cpp
    A llvm/utils/TableGen/Common/Utils.h
    M llvm/utils/TableGen/SubtargetEmitter.cpp

  Log Message:
  -----------
  [TableGen] Rework error reporting for duplicate Feature/Processor (#102257)

- Extract code for sorting and checking duplicate Records into a helper
  function and update `collectProcModels` to use the helper.
- Update `FeatureKeyValues` to:
  (a) Remove code for duplicate checks and use the helper.
  (b) Trim features with empty name explicitly to be able to use
      the helper.
- Make the sorting deterministic by using record name as a secondary
  key for sorting, and re-enable SubtargetFeatureUniqueNames.td test
  that was disabled due to the non-determinism of the error messages.
- Change wording of error message when duplicate records are found to
  be source code position agnostic, since `First` may not be before
  `Second` lexically.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications