[all-commits] [llvm/llvm-project] 5c56b4: [CMake] Fold export_executable_symbols_* into func...

Steven Wu via All-commits all-commits at lists.llvm.org
Mon Aug 5 19:08:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c56b46a32a8856a022a54291bc9294068f7ddbd
      https://github.com/llvm/llvm-project/commit/5c56b46a32a8856a022a54291bc9294068f7ddbd
  Author: Steven Wu <stevenwu at apple.com>
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
    M clang-tools-extra/clang-tidy/tool/CMakeLists.txt
    M clang/tools/clang-linker-wrapper/CMakeLists.txt
    M clang/tools/clang-repl/CMakeLists.txt
    M clang/tools/driver/CMakeLists.txt
    M clang/unittests/Interpreter/CMakeLists.txt
    M clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt
    M flang/tools/flang-driver/CMakeLists.txt
    M lld/tools/lld/CMakeLists.txt
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/examples/ExceptionDemo/CMakeLists.txt
    M llvm/examples/HowToUseLLJIT/CMakeLists.txt
    M llvm/examples/Kaleidoscope/BuildingAJIT/Chapter1/CMakeLists.txt
    M llvm/examples/Kaleidoscope/BuildingAJIT/Chapter2/CMakeLists.txt
    M llvm/examples/Kaleidoscope/BuildingAJIT/Chapter3/CMakeLists.txt
    M llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/CMakeLists.txt
    M llvm/examples/Kaleidoscope/CMakeLists.txt
    M llvm/examples/Kaleidoscope/Chapter4/CMakeLists.txt
    M llvm/examples/Kaleidoscope/Chapter5/CMakeLists.txt
    M llvm/examples/Kaleidoscope/Chapter6/CMakeLists.txt
    M llvm/examples/Kaleidoscope/Chapter7/CMakeLists.txt
    M llvm/examples/Kaleidoscope/Chapter8/CMakeLists.txt
    M llvm/examples/Kaleidoscope/Chapter9/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITDumpObjects/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITRemovableCode/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithCustomObjectLinkingLayer/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithExecutorProcessControl/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithGDBRegistrationListener/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithInitializers/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithLazyReexports/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithObjectCache/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithOptimizingIRTransform/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/CMakeLists.txt
    M llvm/examples/OrcV2Examples/LLJITWithThinLTOSummaries/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsAddObjectFile/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsBasicUsage/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsDumpObjects/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsIRTransforms/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsLazy/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsRemovableCode/CMakeLists.txt
    M llvm/examples/OrcV2Examples/OrcV2CBindingsVeryLazy/CMakeLists.txt
    M llvm/tools/bugpoint/CMakeLists.txt
    M llvm/tools/llc/CMakeLists.txt
    M llvm/tools/lli/CMakeLists.txt
    M llvm/tools/lli/ChildTarget/CMakeLists.txt
    M llvm/tools/llvm-jitlink/CMakeLists.txt
    M llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt
    M llvm/tools/llvm-lto2/CMakeLists.txt
    M llvm/tools/opt/CMakeLists.txt
    M llvm/unittests/Analysis/CMakeLists.txt
    M llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt
    M llvm/unittests/Passes/Plugins/CMakeLists.txt
    M llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
    M mlir/tools/mlir-cpu-runner/CMakeLists.txt
    M mlir/tools/mlir-opt/CMakeLists.txt

  Log Message:
  -----------
  [CMake] Fold export_executable_symbols_* into function args. (#101741)

`LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES` is not completely
compatible with `export_executable_symbols` as the later will be ignored
if the previous is set to NO.

 Fix the issue by passing if symbols need to be exported to
`llvm_add_exectuable` so the link flag can be determined directly
without calling `export_executable_symbols_*` later.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list