[all-commits] [llvm/llvm-project] 3e4af6: [LLDB][SBSaveCore] Implement a selectable threadli...

[Jacob Lalonde via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e4af616334eae532f308605b89ff158dd195180
      https://github.com/llvm/llvm-project/commit/3e4af616334eae532f308605b89ff158dd195180
  Author: Jacob Lalonde <jalalonde at fb.com>
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
    M lldb/include/lldb/API/SBProcess.h
    M lldb/include/lldb/API/SBSaveCoreOptions.h
    M lldb/include/lldb/API/SBThread.h
    M lldb/include/lldb/Symbol/SaveCoreOptions.h
    M lldb/include/lldb/Target/Process.h
    M lldb/source/API/SBSaveCoreOptions.cpp
    M lldb/source/API/SBThread.cpp
    M lldb/source/Core/PluginManager.cpp
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h
    M lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
    M lldb/source/Symbol/SaveCoreOptions.cpp
    M lldb/source/Target/Process.cpp
    M lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
    M lldb/test/API/python_api/sbsavecoreoptions/TestSBSaveCoreOptions.py
    A lldb/test/API/python_api/sbsavecoreoptions/basic_minidump.yaml
    A lldb/test/API/python_api/sbsavecoreoptions/basic_minidump_different_pid.yaml

  Log Message:
  -----------
  [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options.  (#100443)

In #98403 I enabled the SBSaveCoreOptions object, which allows users via
the scripting API to define what they want saved into their core file.
As the first option I've added a threadlist, so users can scan and
identify which threads and corresponding stacks they want to save.

In order to support this, I had to add a new method to `Process.h` on
how we identify which threads are to be saved, and I had to change the
book keeping in minidump to ensure we don't double save the stacks.

Important to @jasonmolenda I also changed the MachO coredump to accept
these new APIs.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications