[all-commits] [llvm/llvm-project] d6cbcf: [lldb][ClangExpressionParser][NFC] Factor out Targ...

Michael Buch via All-commits all-commits at lists.llvm.org
Fri Aug 2 10:13:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6cbcf93b227befaad00957a56acd63c837c26ff
      https://github.com/llvm/llvm-project/commit/d6cbcf93b227befaad00957a56acd63c837c26ff
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h

  Log Message:
  -----------
  [lldb][ClangExpressionParser][NFC] Factor out TargetOpts logic out of ClangExpressionParser (#101681)

Same motivation as https://github.com/llvm/llvm-project/pull/101669. We
plan to eventually use the Clang driver to initialize the
`CompilerInstance`.

This should make refactorings of this code more straightforward.

**Changes**:
* Introduced `SetupTargetOpts`
* Called them from `ClangExpressionParser::ClangExpressionParser`
* Made `GetClangTargetABI` a file-local function since it's not using
any of the state in `ClangExpressionParser`, and isn't used anywhere
outside the source file



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list