[all-commits] [llvm/llvm-project] 93fecc: [lldb] Fixed lldb-server crash (TestLogHandler was...

Dmitry Vasilyev via All-commits all-commits at lists.llvm.org
Wed Jul 31 06:51:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 93fecc2577ece0329f3bbe2719bbc5b4b9b30010
      https://github.com/llvm/llvm-project/commit/93fecc2577ece0329f3bbe2719bbc5b4b9b30010
  Author: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    M lldb/tools/lldb-server/LLDBServerUtilities.cpp

  Log Message:
  -----------
  [lldb] Fixed lldb-server crash (TestLogHandler was not thread safe) (#101326)

Host::LaunchProcess() requires to SetMonitorProcessCallback. This
callback is called from the child process monitor thread. We cannot
control this thread anyway. lldb-server may crash if there is a logging
around this callback because TestLogHandler is not thread safe. I faced
this issue debugging 100 simultaneous child processes. Note
StreamLogHandler::Emit() in lldb/source/Utility/Log.cpp already contains
the similar mutex.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list