[all-commits] [llvm/llvm-project] d69d98: [Tooling] -fsyntax-only adjuster: remove -c and -S

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d69d981d77ee2c9aa740e192d81dabb53c7c3cda
      https://github.com/llvm/llvm-project/commit/d69d981d77ee2c9aa740e192d81dabb53c7c3cda
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M clang/lib/Tooling/ArgumentsAdjusters.cpp
    M clang/test/Tooling/clang-check-extra-arg.cpp

  Log Message:
  -----------
  [Tooling] -fsyntax-only adjuster: remove -c and -S

compile_commands.json entries often have -c. When adding -fsyntax-only,
we should remove -c to prevent the following warning:

```
% clang -c -fsyntax-only a.c
clang: warning: argument unused during compilation: '-c' [-Wunused-command-line-argument]
```

Previously, -c and -S were inappropriately claimed in
`addPGOAndCoverageFlags` (see the workaround added by commit
a07b135ce0c0111bd83450b5dc29ef0381cdbc39). Now the workaround have been
removed (#98607). (clangDriver reports a -Wunused-command-line-argument
diagnostic for each unclaimed option.)

Fix #100909

Pull Request: https://github.com/llvm/llvm-project/pull/101103



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications