[all-commits] [llvm/llvm-project] 65697b: Remove value cache in SCEV comparator. (#100721)

[Johannes Reifferscheid via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 65697b1c7cc9824d51f22f109c6a32428a7dd557
      https://github.com/llvm/llvm-project/commit/65697b1c7cc9824d51f22f109c6a32428a7dd557
  Author: Johannes Reifferscheid <jreiffers at google.com>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M llvm/lib/Analysis/ScalarEvolution.cpp
    M llvm/unittests/Analysis/ScalarEvolutionTest.cpp

  Log Message:
  -----------
  Remove value cache in SCEV comparator. (#100721)

The cache triggers almost never, and seems unlikely to help with
performance. However, when it does, it is likely to cause the comparator
to become inconsistent due to a bad interaction of the depth limit and
cache hits. This leads to crashes in debug builds. See the new unit test
for a reproducer.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications