[all-commits] [llvm/llvm-project] f6a928: [Support][NFC] Simplify DomTreeNodeBase::addChild ...

[Alexis Engelke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f6a928a532543a5db4ab89fccbede42f8df32f0f
      https://github.com/llvm/llvm-project/commit/f6a928a532543a5db4ab89fccbede42f8df32f0f
  Author: Alexis Engelke <engelke at in.tum.de>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M llvm/include/llvm/Support/GenericDomTree.h
    M llvm/include/llvm/Support/GenericDomTreeConstruction.h

  Log Message:
  -----------
  [Support][NFC] Simplify DomTreeNodeBase::addChild (#101056)

Previously, the method would take the unique_ptr, store the pointer in
its Children vector, and then return the unique_ptr. Pass the raw
pointer as parameter instead. Also merge createChild and createNode to
avoid code duplication.

This was added in a72d6ef891707173b when introducing unique_ptr,
previously this was a source code size optimization.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications