[all-commits] [llvm/llvm-project] 11a7ee: [lldb][TypeSystemClang][NFC] Clean up TypeSystemCl...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 11a7ee50b400fc13cf772c81e09c153c93665658
      https://github.com/llvm/llvm-project/commit/11a7ee50b400fc13cf772c81e09c153c93665658
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-07-26 (Fri, 26 Jul 2024)

  Changed paths:
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h

  Log Message:
  -----------
  [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (#100674)

This patch performs following NFC changes to
TypeSystemClang::GetBitSize:
* Factor out the Objective-C logic into a helper function.
* Introduce a new case for `FunctionProto`. I don't see a good reason
for special-casing this in the `default` case.
* We had a redundant check for `GetCompleteType` in the `RecordType`
case. We used to allow zero-size types for records and function
prototypes, so we can just fold them into the same case.
* Introduce a new case for `IncompleteArray`.

The motivation for this is that there are a few issues around VLAs
(i.e., `Type::IncompleteArray`) whose fixes will be easier to reason
about after this refactor.

Generally I don't think treating a type with 0 size as an error is the
right thing to do (at least not for array types). But that's not
something I wanted to fold into this NFC change.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications