[all-commits] [llvm/llvm-project] f48c16: [lldb][Linux] Parse, but don't store "comm" from /...

David Spickett via All-commits all-commits at lists.llvm.org
Thu Jul 25 01:15:26 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f48c16631de07b47e0721b88bd8004e63897f29a
      https://github.com/llvm/llvm-project/commit/f48c16631de07b47e0721b88bd8004e63897f29a
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
    M lldb/source/Host/linux/Host.cpp

  Log Message:
  -----------
  [lldb][Linux] Parse, but don't store "comm" from /proc/stat file (#100387)

As reported in https://github.com/llvm/llvm-project/issues/89710, the %s
code used for `comm` could and probably does, overflow the buffer.
Likely we haven't seen it cause problems because the following data is
overwritten right afterwards.

Also scanf isn't a great choice here as this `comm` can include many
characters that might trip up %s.

We don't actually use `comm`, so parse but don't store it so we're not
overflowing anything.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list