[all-commits] [llvm/llvm-project] 636740: DebugInfo: Avoid some MMI::hasDebugInfo checks

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/avoid-checking-mmi-hasdebuginfo
  Home:   https://github.com/llvm/llvm-project
  Commit: 6367409181a47493058cede13de0b623d59e4b45
      https://github.com/llvm/llvm-project/commit/6367409181a47493058cede13de0b623d59e4b45
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp

  Log Message:
  -----------
  DebugInfo: Avoid some MMI::hasDebugInfo checks

I assume getSubprogram will do the correct thing in hasDebugInfo,
and this is redundant with the debug_compile_units distance check.
This is in preparation for removing the field.


  Commit: 1e3fdb2a58c6709e4d69fd0facdfdec6916802be
      https://github.com/llvm/llvm-project/commit/1e3fdb2a58c6709e4d69fd0facdfdec6916802be
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/FastISel.cpp

  Log Message:
  -----------
  FastISel: Do not check for module debug info

I don't see the point of this check and SelectionDAG
does not perform it. In the normal usecase, if there's
no debug info the debug intrinsics would not be there
in the first place.


Compare: https://github.com/llvm/llvm-project/compare/442532e0d500...1e3fdb2a58c6

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications