[all-commits] [llvm/llvm-project] ae1de3: [Flang] Remove tests checking now removed 'libc-gp...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae1de3ea3c2db722bb2b135fe2c29b14b9ae1bcc
      https://github.com/llvm/llvm-project/commit/ae1de3ea3c2db722bb2b135fe2c29b14b9ae1bcc
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M flang/test/Driver/omp-driver-offload.f90

  Log Message:
  -----------
  [Flang] Remove tests checking now removed 'libc-gpu.a`

Summary:
These tests were removed in a previous patch.

The linker wrapper now just extracts the device inputs and forwards them
directly to the device's link job. This is the job that occurs when you
do `clang --target=amdgcn-amd-amdhsa foo.o` or similar. Because this can
handle LTO we no longer do LTO in the linker wrapper. This has some
fallout, because we now require `ld.lld` to be built with a compatible
version, but I think we always expected that.

I made the decision to remove this `libc-gpu.a` library because it was
unnecessary and complicated things. Now I simply have the link job
implicitly link `-lc` if it exists. Users can also now pass
`-Xoffload-linker=amdgcn-amd-amdhsa -lc` or similar to pass it. Because
of this, these tests need to be removed. I forgot that Fortran also had
these.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications