[all-commits] [llvm/llvm-project] b316ce: [AMDGPU][MC] Improve error message for missing dim...

[Jun Wang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b316cebae1a4de242b6723e1dd8b37b12f72ca8d
      https://github.com/llvm/llvm-project/commit/b316cebae1a4de242b6723e1dd8b37b12f72ca8d
  Author: Jun Wang <jwang86 at yahoo.com>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/test/MC/AMDGPU/gfx1030_err.s
    M llvm/test/MC/AMDGPU/gfx10_asm_mimg_err.s
    M llvm/test/MC/AMDGPU/gfx10_err_pos.s
    M llvm/test/MC/AMDGPU/gfx11_asm_mimg_err.s
    A llvm/test/MC/AMDGPU/gfx12_asm_mimg_err.s
    M llvm/test/MC/AMDGPU/gfx12_err.s

  Log Message:
  -----------
  [AMDGPU][MC] Improve error message for missing dim operand (#96588)

For GFX10+, the MIMG instrucitons generally require a dim operand.
However, when dim is missing, the assembler produces the error message
"operands are not valid for this GPU or mode" (See issue
https://github.com/llvm/llvm-project/issues/47585). This patch fixes the
issue by producing a more direct error message.

---------

Co-authored-by: Jun Wang <jun.wang7 at amd.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications