[all-commits] [llvm/llvm-project] aac3a2: [libc] Fix callback type in `exit_handlers.cpp` no...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Jul 22 13:29:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aac3a2a291598f3aef01833927fa754c53849cdf
      https://github.com/llvm/llvm-project/commit/aac3a2a291598f3aef01833927fa754c53849cdf
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M libc/src/stdlib/CMakeLists.txt
    M libc/src/stdlib/at_quick_exit.cpp
    M libc/src/stdlib/atexit.cpp
    R libc/src/stdlib/exit_handler.cpp
    M libc/src/stdlib/exit_handler.h

  Log Message:
  -----------
  [libc] Fix callback type in `exit_handlers.cpp` not matching (#97642)

Summary:
This file is an object library, but uses the `LIBC_COPT_PUBLIC_PACKAING`
option. This will always be undefined which leads to a type mismatch
when uses actually try to link against it. This patch simply removes
this and turns it into a header only library. This means that the
implementations of the callback lists and the mutexes need to live in
their respective files. The result is that `atexit` needs to be defined
for `at_quick_exit` to be valid.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list